Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Smart Detection behavior #28

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

veler
Copy link
Collaborator

@veler veler commented Oct 12, 2021

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

  • When using Smart Detection, if 2 tools or more were recommended, the clipboard data would never been paste in the tool.
  • When using Smart Detection, users should have the choice to automatically paste data or note.

Issue Number: #20, #21

What is the new behavior?

  • Added a new option to disable the automatic clipboard data insertion
  • Changed the Smart Detection behavior so we paste automatically when a recommended tool is selected.

image

Other information

The clipboard data won't be paste if:

  • We selected a non-recommended tool before the recommended one
  • The clipboard data has already been paste.
  • The clipboard data didn't change since the last time the window had the focus
  • The recommended tools are the same than the last time the window had the focus

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants