Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimmed input string for the JwtDecoderEncoder #399

Merged
merged 1 commit into from Feb 18, 2022
Merged

Trimmed input string for the JwtDecoderEncoder #399

merged 1 commit into from Feb 18, 2022

Conversation

michael-hoedl
Copy link
Contributor

@michael-hoedl michael-hoedl commented Feb 15, 2022 •
edited

FIX

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Currently, if there is an empty space in the input for the JWT decoder, the decoding will fail.

Issue Number: #391

What is the new behavior?

  • With the fix, the input string gets trimmed, so that any empty spaces will be removed.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue Feb 18, 2022 that may be closed by this pull request
JWT decoder should trim the input #391
Closed
veler
veler approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Good catch! Thank you very much for your contribution :)

@veler veler merged commit 558163d into DevToys-app:main Feb 18, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
@michael-hoedl
Trimmed input string for the JwtDecoderEncoder (#399)
175b7a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veler veler veler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JWT decoder should trim the input
2 participants
@michael-hoedl @veler