#403 - Checksum Generator is wrong about gz file hash #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-hoedl
changed the title
11 tasks
veler
approved these changes
Feb 18, 2022
veler
pushed a commit
that referenced
this pull request
Mar 31, 2023
* Simplified the ComputeHashAsync method * Progess and cancelation now also gets checked after the TransformFinalBlock call * fixed a typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX / QOL improvements
Please check the type of change your PR introduces:
What is the current behavior?
Currently, if there is an archive > 2 MB, the checksum generator generates false checksums.
Issue Number: #403
What is the new behavior?
I simplified the method, so its easier to read and now correctly functions.
Other information
If needed, i can expand the unit tests, so an array with an aproximated size of 15 MB get's checked.
Quality check
Before creating this PR, have you: