Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added handling of out-of-range numbers and leap years. #466

Merged
merged 1 commit into from Mar 29, 2022
Merged

Added handling of out-of-range numbers and leap years. #466

merged 1 commit into from Mar 29, 2022

Conversation

niyari
Copy link
Contributor

@niyari niyari commented Mar 27, 2022 •
edited by veler

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #474

What is the new behavior?

  • Fix leap years.
  • Fix errors when setting year 0, month 0, or blank fields.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue Mar 29, 2022 that may be closed by this pull request
Unix Timestamp Converter #474
Closed
@veler
Copy link
Collaborator

veler commented Mar 29, 2022

Hello,
That looks great, very good catch :) Thanks for addressing this issue!

@veler veler merged commit ff8dd15 into DevToys-app:main Mar 29, 2022
@niyari niyari deleted the patch-timestamp branch March 29, 2022 04:45
@niyari niyari mentioned this pull request Mar 29, 2022
Closed
veler pushed a commit that referenced this pull request Mar 31, 2023
@niyari
Added handling of out-of-range numbers and leap years. (#466)
01f0454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veler veler veler approved these changes

@Andret2344 Andret2344 Andret2344 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unix Timestamp Converter
3 participants
@niyari @veler @Andret2344