Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of out-of-range numbers and leap years. #478

Merged
merged 2 commits into from
Apr 3, 2022
Merged

Fix handling of out-of-range numbers and leap years. #478

merged 2 commits into from
Apr 3, 2022

Conversation

niyari
Copy link
Contributor

@niyari niyari commented Mar 30, 2022 •
edited
Loading

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: #477

What is the new behavior?

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@niyari niyari marked this pull request as ready for review March 30, 2022 06:46
veler
veler approved these changes Apr 3, 2022
View reviewed changes
Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thank you very much for this fix! And sorry for the late review.

@veler veler merged commit 0ff7945 into DevToys-app:main Apr 3, 2022
@niyari niyari deleted the patch-1 branch April 4, 2022 06:39
veler pushed a commit that referenced this pull request Mar 31, 2023
@niyari
Fix handling of out-of-range numbers and leap years. (#478)
87cbcf5 
* Fix handling of out-of-range numbers and leap years.

* Update TimestampToolViewModel.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veler veler veler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unix Timestamp Converter - Handling of non-existent dates
2 participants
@niyari @veler