Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed title being hidden under header. #495

Merged
merged 2 commits into from Apr 17, 2022
Merged

Conversation

Atria64
Copy link
Contributor

@Atria64 Atria64 commented Apr 15, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number:

What is the new behavior?

  • ScrollViewerContent does not expand too much when the application screen area is small.
    • So, adjusted ScrollViewerContent.Margin when VisualState is NavigationViewMinimal.

Other information

Before After
image image

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@veler veler linked an issue Apr 16, 2022 that may be closed by this pull request
@veler
Copy link
Collaborator

veler commented Apr 16, 2022

Hello,
Thanks for this contribution. :)

I see that there is a similar bug with the Compact mode:
image

image

Any chance we could fix it in this PR too? I admit I didn't investigate what the issue, but please let me know if you want some help with it. :)

Thank you very much again! :D

@Atria64
Copy link
Contributor Author

Atria64 commented Apr 17, 2022

Hello!
I have fixed the bug in compact mode as I have confirmed that it occurs!

Before After
image image

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thanks for the update, it seems to work very well now :D
Thank you so much for your contribution!

@veler veler merged commit 9d331bb into DevToys-app:main Apr 17, 2022
@veler veler added this to the v1.0.7.0 milestone May 15, 2022
veler pushed a commit that referenced this pull request Mar 31, 2023
* Fixed title being hidden under header.

* Fix in Compact mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are hiding title
2 participants