#483 Added Now button to bring timestamp to current date and time. #515
Conversation
There was a problem hiding this comment.
Hello,
Thanks for this contribution. It looks good overall. Can you please change the text in the .resw that have been translated through a tool like Google Translate to keep it in English (Now) ? We can then let translators, who are better than Google Translate, translate the language correctly.
Thank you :)
| @@ -168,6 +168,9 @@ | |||
| <data name="Megabytes" xml:space="preserve"> | |||
| <value>MO</value> | |||
| </data> | |||
| <data name="Now" xml:space="preserve"> | |||
| <value>À présent</value> | |||
There was a problem hiding this comment.
I'd suggest to keep the word in English for language that you may not be fluent with, and let people who are comfortable with the language translating it. Here is an example: while À présent is correct literal translation of Now, in this context, it's incorrect and is confusing. The correct one would be Maintenant.
There was a problem hiding this comment.
Fixed in cbf2329.
I wasn't sure if English or Google Translate was preferred in contributions. Now I know. 👍
…nslation by native speakers.
) * #483 Added Now button to bring timestamp to current date and time. * Removing Google Translate translations, switch all to English for translation by native speakers.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Introduces request from #483 which asks to have a Now button. The button could also be labeled "Reset", but the term "Now" is more explicit about what the button intends to do (set all times to the current date and time).
Issue Number: #483
What is the new behavior?
Other information
Quality check
Before creating this PR, have you: