Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SearchKeywords value. #547

Merged
merged 1 commit into from May 29, 2022
Merged

fix SearchKeywords value. #547

merged 1 commit into from May 29, 2022

Conversation

niyari
Copy link
Contributor

@niyari niyari commented May 28, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Remove unnecessary strings automatically added by external services.

Other information

Quality check

Before creating this PR, have you:

  • Followed the code style guideline as described in CONTRIBUTING.md
  • Verified that the change work in Release build configuration
  • Checked all unit tests pass

@niyari
Copy link
Contributor Author

niyari commented May 28, 2022

I assume this is a Crowdin specification, but when the original text is empty, some keys cannot be edited by the translator and some keys can.
(This will not be a problem for many projects because it prevents translation of sentences that are empty.)
image

Is there a setting on the Crowdin side that can be set to allow or disallow editing?
This is a suggestion to deal with the case where there is no such setting.
When implementing Search Keywords ( #365 ), the system is designed so that strings already included in tool names, etc. are not affected.
By putting the tool name, etc. in the en-US value, the translator can edit it.

@niyari niyari marked this pull request as ready for review May 28, 2022 15:24
@veler
Copy link
Collaborator

veler commented May 28, 2022

Indeed, that's the issue. Good catch! I wonder however if we should fix that directly in Crowdin instead?

@niyari
Copy link
Contributor Author

niyari commented May 28, 2022

Yes, the file in the current pull request is the one that should be edited using Crowdin.
Files that could not be modified from Crowdin are included in the pull request.

Other than PR files, SearchKeywords in the LoremIpsumGenerator.resw file is empty in en-US, but I was able to change it in Crowdin, from Checksum to 仮文章.
If words related to en-US SearchKeywords are prepared, they can be translated.(probably.)

@veler
Copy link
Collaborator

veler commented May 29, 2022

Gotcha, thank you very much :)

@veler veler merged commit df29ca6 into DevToys-app:main May 29, 2022
@niyari niyari deleted the patch-1 branch May 30, 2022 22:26
veler pushed a commit that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants