Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage favorites for recommended tool providers #626

Merged
merged 1 commit into from Aug 18, 2022
Merged

Leverage favorites for recommended tool providers #626

merged 1 commit into from Aug 18, 2022

Conversation

C1rdec
Copy link
Contributor

@C1rdec C1rdec commented Aug 3, 2022

Please check the type of change your PR introduces:

  • [✓] Feature

What is the current behavior?

Like discussed in Issue 600
Even if there's multiple recommended ToolProviders, the tool selection is triggered if there's one in the favorites.

Issue Number: 600

Quality check

Before creating this PR, have you:

  • [✓] Followed the code style guideline as described in CONTRIBUTING.md
  • [✓] Verified that the change work in Release build configuration
  • [✓] Checked all unit tests pass

@C1rdec C1rdec changed the title Leverage favorite system for recommended tool providers Leverage favorites for recommended tool providers Aug 4, 2022
@C1rdec
Copy link
Contributor Author

C1rdec commented Aug 18, 2022

@veler Any idea when this can be reviewed I'm using it locally and the UX is awesome!

Copy link
Collaborator

@veler veler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Sorry for the late review. I love it! :D It works great! Thank you so much for this contribution. I will merge this PR and it will be part of the next update.

@veler veler merged commit 10977f8 into DevToys-app:main Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants