Features/jwt decoder encoder tool update #645
Conversation
|
UI feedback: 1The grid gripper should be vertical, and the title is missing on some text input:
Same issue with the icon in Decoder mode. 2This UI below feels a bit too busy.
How about hidding
|
src/dev/impl/DevToys/Models/JwtDecoderEncoder/DecoderParameters.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/Models/JwtDecoderEncoder/EncoderParameters.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/ViewModels/Tools/EncodersDecoders/JwtDecoderEncoder/JwtToolJobItem.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/Views/Tools/EncodersDecoders/JwtDecoderEncoder/JwtDecoderControl.xaml.cs
Outdated
Show resolved
Hide resolved
src/dev/impl/DevToys/Views/Tools/EncodersDecoders/JwtDecoderEncoder/JwtEncoderControl.xaml.cs
Outdated
Show resolved
Hide resolved
| _validationResult = null; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Kudo for adding 60+ tests :D This is great! I see 8 tests failing on my machine though 🤔
Do they pass on your machine? If yes, perhaps it's the sign of a race condition.
There was a problem hiding this comment.
Hum these tests Passed in devops too. Can you get the errors?
There was a problem hiding this comment.
Alright, they seem to all crash on this line:
There was a problem hiding this comment.
Hum, that's the problem with the expires date and time zone. I'm checking.
…thub.com/veler/DevToys into features/jwt-decoder-encoder-tool-update
| @@ -50,4 +50,5 @@ private async Task TreatComputationQueueAsync() | |||
| } | |||
| } | |||
| } | |||
|
|
|||
|
|
||
| if (decodeParameters.ValidateAudience) | ||
| { | ||
| if (!tokenParameters.ValidAudiences.Any()) |
There was a problem hiding this comment.
Sorry, bad habit from work they don't like Count and prefer Any...
Did you tell them that .Any() has to instantiate an Enumerator, which means extra allocation and computation while Count has a O(1) ?
| _validationResult = null; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Alright, they seem to all crash on this line:
…thub.com/veler/DevToys into features/jwt-decoder-encoder-tool-update
* added jwt encoder and jwt decoder signature verification * reworked jwt decoder / encoder * updated following comments * fixed small bug on ui * Fixed a bug in CustomTextBox * update token date to use UTC * updated for some small ui fixes Co-authored-by: Etienne BAUDOUX <ebaudoux@velersoftware.com>
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issues with the JWT Detection.
No JWT Encoder.
Issue Number:
What is the new behavior?
Other information
Quality check
Before creating this PR, have you: