Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing Vertical Stretch of JWT Header and Payload sections #768

Merged
merged 1 commit into from Mar 19, 2023

Conversation

bowencode
Copy link

@bowencode bowencode commented Mar 13, 2023

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • UI change (please include screenshot!)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Internationalization and localization
  • Other (please describe):

What is the current behavior?

JWT Encoder/Decoder uses only a fixed amount of vertical space for Payload. With short tokens this just leaves empty visual space at the bottom but for tokens with many claims it requires scrolling no matter what size the window is.

Issue Number: N/A

What is the new behavior?

  • Encoder and Decoder Page expands vertically to fill available window space
  • Header and Payload sections expand vertically to fill the available page space
  • Minimum vertical sizes are unchanged so still enable scrolling on short window heights

Other information

Behavior Before:
VerticalStretchBefore

Behavior After:
VerticalStretchAfter

Quality check

Before creating this PR, have you:

  • [ x ] Followed the code style guideline as described in CONTRIBUTING.md
  • [ x ] Verified that the change work in Release build configuration
  • [ x ] Checked all unit tests pass

@veler veler requested a review from btiteux March 13, 2023 14:58
@veler
Copy link
Collaborator

veler commented Mar 19, 2023

Thanks for this improvement! Not sure if it will be part of the DevToys 1.0 as we actively work on DevToys 2.0. But it will definitely be in 2.0 version :D

@veler veler merged commit f10c498 into DevToys-app:main Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants