Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added plugin option 'archiverOptions' #5

Merged
merged 1 commit into from Jan 26, 2018
Merged

Added plugin option 'archiverOptions' #5

merged 1 commit into from Jan 26, 2018

Conversation

hakla
Copy link
Contributor

@hakla hakla commented Nov 1, 2017

I added an option so the user can specify options for archiver. Would be cool if you could merge those changes.

Cheers!

@coveralls
Copy link

coveralls commented Nov 1, 2017 •
edited

Coverage Status

Coverage increased (+0.7%) to 86.885% when pulling 069366f on hakla:master into 631d3b0 on DevWurm:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 86.885% when pulling 069366f on hakla:master into 631d3b0 on DevWurm:master.

@DevWurm
Copy link
Owner

DevWurm commented Nov 1, 2017

Great, thank you!
Would it be possible for you to add a test case for this option and maybe test it in a functional test fixture?

@DevWurm DevWurm changed the base branch from master to feature/archiver-options January 26, 2018 10:45
@DevWurm DevWurm merged commit 384a73f into DevWurm:feature/archiver-options Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hakla @coveralls @DevWurm