Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced use of DjsUtil.delayFor #474

Merged
merged 2 commits into from
Jan 16, 2022
Merged

Conversation

optimisticside
Copy link
Contributor

delayFor is not a function of discord.js's Util library.

@DevYukine
Copy link
Owner

Hey, thanks for this PR, can you just import setTimeout without renaming it to delayFor and just change the name where the function is called? i think thats more intuitive :)

otherwise LGTM

@optimisticside
Copy link
Contributor Author

setTimeout is already a global function, and would cause confusion. I could call the function wait or use it through the library by doing something like Timers.setTimeout.

@DevYukine
Copy link
Owner

calling it wait sounds fine to me 👍

@optimisticside
Copy link
Contributor Author

I realized there's already a function in Util called sleep which does the same thing, so I'll just use that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants