pass movie item with parcelable

Devdroid-Android · Jun 16, 2023 · d850dbe · d850dbe
1 parent c362587
commit d850dbe
Show file tree

Hide file tree

Showing 7 changed files with 202 additions and 195 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -2,6 +2,7 @@ plugins {
     id 'com.android.application'
     id 'org.jetbrains.kotlin.android'
     id "org.jlleitschuh.gradle.ktlint" version "11.3.1"
+    id 'kotlin-parcelize'
 }
 
 android {

diff --git a/app/src/main/java/com/satyamthakur/silver/MainActivity.kt b/app/src/main/java/com/satyamthakur/silver/MainActivity.kt
@@ -1,35 +1,22 @@
 package com.satyamthakur.silver
 
-import android.os.Build
 import android.os.Bundle
 import androidx.activity.ComponentActivity
+import androidx.activity.compose.BackHandler
 import androidx.activity.compose.setContent
 import androidx.compose.animation.ExperimentalAnimationApi
 import androidx.compose.foundation.layout.fillMaxSize
 import androidx.compose.foundation.layout.padding
-import androidx.compose.material3.CenterAlignedTopAppBar
 import androidx.compose.material3.ExperimentalMaterial3Api
-import androidx.compose.material3.MaterialTheme
 import androidx.compose.material3.Scaffold
 import androidx.compose.material3.Surface
-import androidx.compose.material3.Text
-import androidx.compose.runtime.Composable
 import androidx.compose.runtime.getValue
 import androidx.compose.ui.Modifier
-import androidx.compose.ui.res.stringResource
-import androidx.compose.ui.text.font.FontWeight
-import androidx.compose.ui.unit.sp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
-import androidx.navigation.NavController
-import androidx.navigation.NavType
 import androidx.navigation.compose.NavHost
 import androidx.navigation.compose.composable
-import androidx.navigation.navArgument
 import com.google.accompanist.navigation.animation.rememberAnimatedNavController
-import com.google.gson.Gson
 import com.satyamthakur.silver.domain.model.Movie
-import com.satyamthakur.silver.domain.model.MovieArgumentType
-import com.satyamthakur.silver.domain.model.PopularMovies
 import com.satyamthakur.silver.ui.screen.dashboard.DashboardScreen
 import com.satyamthakur.silver.ui.screen.dashboard.movie.MovieScreen
 import com.satyamthakur.silver.ui.screen.dashboard.viewmodel.DashboardViewModel
@@ -47,30 +34,18 @@ class MainActivity : ComponentActivity() {
             val viewModel = koinViewModel<DashboardViewModel>()
             val nowShowingMovies by viewModel.nowShowingMovies.collectAsStateWithLifecycle()
             val popularMovies by viewModel.popularMovies.collectAsStateWithLifecycle()
-            val creditsData by viewModel.credits.collectAsStateWithLifecycle()
 
             SilverTheme {
                 Surface {
                     Scaffold(
-                        topBar = {
-                            CenterAlignedTopAppBar(title = {
-                                Text(
-                                    text = stringResource(id = R.string.app_name),
-                                    style = MaterialTheme.typography.titleMedium.copy(
-                                        fontWeight = FontWeight.Black,
-                                        fontSize = 16.sp
-                                    )
-                                )
-                            })
-                        }
+
                     ) { paddingValues ->
                         NavHost(
                             navController = navController,
                             startDestination = Screen.Dashboard.route
                         ) {
                             composable(route = Screen.Dashboard.route) {
 
-
                                 DashboardScreen(
                                     onMovieClicked = {},
                                     onSeeMoreNowShowingMovies = {},
@@ -85,24 +60,14 @@ class MainActivity : ComponentActivity() {
                                     navController = navController
                                 )
                             }
-                            composable(route = Screen.MovieScreen.route
-                                    + "/{movieItem}",
-                                arguments = listOf(
-                                    navArgument("movieItem"){
-                                        type = NavType.SerializableType(Movie::class.java)
-                                    }
-                                )
-                            ){ navBackStackEntry ->
-
-                                val movieItem = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
-                                    navBackStackEntry.arguments?.getSerializable("movieItem", Movie::class.java)
-                                } else {
-                                    navBackStackEntry.arguments?.getSerializable("movieItem")
-                                } as Movie
-
-                                MovieScreen(movie = movieItem, creditsData )
+                            composable(route = Screen.MovieScreen.route){
+                                val movieItem = navController.previousBackStackEntry?.savedStateHandle?.get<Movie>("movie")
+                                MovieScreen(movie = movieItem!!, navController = navController)
                             }
                         }
+                        BackHandler(true) {
+                            navController.popBackStack()
+                        }
                     }
                 }
             }

diff --git a/app/src/main/java/com/satyamthakur/silver/data/repository/MovieRepository.kt b/app/src/main/java/com/satyamthakur/silver/data/repository/MovieRepository.kt
@@ -14,6 +14,7 @@ import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.flow.Flow
 import kotlinx.coroutines.flow.catch
 import kotlinx.coroutines.flow.distinctUntilChanged
+import kotlinx.coroutines.flow.filter
 import kotlinx.coroutines.flow.flow
 import kotlinx.coroutines.flow.flowOn
 import kotlinx.coroutines.flow.onStart
@@ -75,7 +76,7 @@ class MovieRepository(
                     message = errorParser(t)
                 )
             )
-        }.distinctUntilChanged().onStart {
+        }.onStart {
             emit(Resource.Loading)
         }.flowOn(ioDispatcher)
     }
@@ -96,7 +97,7 @@ class MovieRepository(
                     message = errorParser(t)
                 )
             )
-        }.distinctUntilChanged().onStart {
+        }.onStart {
             emit(Resource.Loading)
         }.flowOn(ioDispatcher)
     }

diff --git a/app/src/main/java/com/satyamthakur/silver/domain/model/Movie.kt b/app/src/main/java/com/satyamthakur/silver/domain/model/Movie.kt
@@ -1,11 +1,9 @@
 package com.satyamthakur.silver.domain.model
 
-import android.os.Bundle
-import com.google.gson.Gson
-import com.google.gson.annotations.JsonAdapter
-import com.satyamthakur.silver.utility.JsonNavType
-import java.io.Serializable
+import android.os.Parcelable
+import kotlinx.parcelize.Parcelize
 
+@Parcelize
 data class Movie(
     val adult: Boolean,
     val backdropPath: String,
@@ -21,14 +19,7 @@ data class Movie(
     val video: Boolean,
     val voteAverage: Double,
     val voteCount: Int
-) : Serializable
-
-class MovieArgumentType: JsonNavType<Movie>(){
-    override fun fromJsonParse(value: String): Movie = Gson().fromJson(value, Movie::class.java)
-
-    override fun Movie.getJsonParse(): String = Gson().toJson(this)
-
-}
+) : Parcelable
 
 val PopularMovies: List<Movie> = listOf(
     Movie(