Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamburger menu for responsive navbar #41

Merged
merged 7 commits into from
Nov 25, 2021

Conversation

miralsuthar
Copy link
Contributor

What does it do?

Add hamburger menu navbar for mobile view

Does it close any issue?

it closes issue #10

@vercel
Copy link

vercel bot commented Nov 16, 2021

@miralsuthar is attempting to deploy a commit to the Developerdao Team on Vercel.

A member of the Team first needs to authorize it.

@miralsuthar
Copy link
Contributor Author

@angeljgomezc just put PR for issue #10 for adding the hamburger menu in the navbar for mobile responsiveness.

@Dhaiwat10 Dhaiwat10 self-requested a review November 16, 2021 18:41
@vercel
Copy link

vercel bot commented Nov 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/developdao/dao-job-board/5fGcXb6HPkfaFYJWn8ZCNQqGu5R4
✅ Preview: https://dao-job-board-git-fork-miralsuthar-feat-hambu-d371b1-developdao.vercel.app

[Deployment for 6012bdf failed]

Copy link
Member

@with-heart with-heart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple pieces of feedback for you!

Also this project recently switched from npm to yarn, so you'll want to delete client/package-lock.json and run yarn to install packages instead.

client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
client/components/navigation/Navbar.tsx Outdated Show resolved Hide resolved
@4gnle
Copy link
Contributor

4gnle commented Nov 19, 2021

@with-heart fixed Miral's PR to avoid conflicts with my last PR. Check this whenever you can and preview the Navbar. THANK YOU!

@4gnle
Copy link
Contributor

4gnle commented Nov 23, 2021

Finished the last few touches for the hamburger menu to be ready for deployment in the main branch. @with-heart would love your feedback on this component

https://github.com/Developer-DAO/DAO-job-board/blob/07f3d17a52186d68b0582ad41848c0c68fcae3ef/client/components/navigation/Navbar.tsx

Co-authored-by: with-heart <with.heart+git@pm.me>
@4gnle 4gnle merged commit 13d05c3 into Developer-DAO:main Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants