support wallet logon #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JoviDeCroock is attempting to deploy a commit to the Developerdao Team on Vercel. A member of the Team first needs to authorize it. |
JoviDeCroock
commented
Nov 19, 2021
JoviDeCroock
commented
Nov 19, 2021
carlomigueldy
suggested changes
Nov 19, 2021
There was a problem hiding this comment.
Awesome stuff @JoviDeCroock !
Just got a rename request for the attribute to store the wallet address and let's add nonce
Merged
with-heart
reviewed
Nov 20, 2021
|
Thanks for the reviews! I'll wait for the database changes to go live, then test and convert to "ready for review" |
Merged my PR and updated the database, you can test out the new changes. |
carlomigueldy
approved these changes
Nov 21, 2021
JoviDeCroock
commented
Nov 21, 2021
| @@ -17,19 +17,20 @@ | |||
| "@usedapp/core": "^0.5.4", | |||
| "babel-plugin-styled-components": "^1.13.3", | |||
| "cross-env": "^7.0.3", | |||
| "doppler": "^1.0.0", | |||
There was a problem hiding this comment.
Noticed this was unused and not present in the lockfile. Removed it as it's unused and a risk for versioning 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in anticipation of the new database schema, this allows us to logon using our
metamask/... wallet. We send the address provided by the wallet up to/api/authand this will send us back whether or not we're valid and create/give us back an account from supabase.After that we can redirect our user to
/create-profilewhen they're new or to/jobsresolves #4