Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] 로컬라이징 적용 (영어, 일본어, 한국어) #113

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[Feat] 로컬라이징 적용 (영어, 일본어, 한국어) #113

wants to merge 5 commits into from

Conversation

JIWON1923
Copy link
Member

Keychanges

  • 로컬라이즈 파일 생성 및 번역 (영어, 일본어, 한국어 지원)
  • 로컬라이징 적용

Screenshots

한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 07 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 45 08 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 59 28
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 10 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 45 15 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 00 04
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 14 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 45 30 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 01 00
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 17 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 45 34 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 01 05
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 21 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 15 58 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 01 09
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 25 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 50 01 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 01 13
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 40 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 55 31 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 02 19
한국어 영어 일본어
Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 03 44 Simulator Screenshot - iPhone 14 - 2023-07-09 at 13 58 34 Simulator Screenshot - iPhone 14 - 2023-07-09 at 14 02 23

To Reviewer

  • iPhone 14 기준으로 디자인을 해치지 않는 선에서 번역했습니다.
  • 추후 사용자의 언어 선택에 따라 검색 결과도 국제화할 수 있도록 작업 할 예정입니다.

@JIWON1923 JIWON1923 added the 🌟 enhancement New feature or request label Jul 9, 2023
@JIWON1923 JIWON1923 self-assigned this Jul 9, 2023
YunSeok-Choi
YunSeok-Choi approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@YunSeok-Choi YunSeok-Choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

번역하시느라 고생 많으셨습니다!! LGTM!

@JMM00
Copy link
Member

JMM00 commented Jul 15, 2023

글로벌한 앱이 되어가는 것 같아서 너무 좋아요👍 수고하셨습니다!

@JIWON1923
Copy link
Member Author

@YunSeok-Choi
로컬라이징 적용했을 때, 이슈가 있어서 뷰 코드 조금 수정했습니다! 확인 부탁드려요

이슈화면 해결화면

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM00 JMM00 JMM00 approved these changes

@YunSeok-Choi YunSeok-Choi Awaiting requested review from YunSeok-Choi

Assignees

@JIWON1923 JIWON1923

Labels
🌟 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 로컬라이징
3 participants
@JIWON1923 @JMM00 @YunSeok-Choi