Feat: CdListView #13
Merged
Feat: CdListView #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
확인했습니다! |
| @Published var screenDrag: Float = 0.0 | ||
| } | ||
|
|
||
| struct Carousel<Items : View> : View { |
There was a problem hiding this comment.
어디에 들어가는 뷰인지 주석 달아주시면 좋을 것 같아요
Comment on lines
+21
to
+30
| // Text("아직 기록된 음악이 없어요") | ||
| // .font(Font.customTitle2()) | ||
| // .foregroundColor(.titleGray) | ||
| // .padding(.bottom, 12) | ||
| // .padding(.top, 260) | ||
| // Button("음악 기록하러 가기") { | ||
| // //go to WriteView | ||
| // } | ||
| // Spacer() | ||
| // Image("ListViewCdPlayer") |
There was a problem hiding this comment.
필요 없는 내용이면 삭제해도 좋을 것 같습니다
There was a problem hiding this comment.
리스트가 없을 때 쓰는 코드라 필요한 코드입니다! 아직 데이터를 안받아와서 주석처리 해놨어요!
| var image: String = "" | ||
| } | ||
|
|
||
| public class UIStateModel: ObservableObject { |
There was a problem hiding this comment.
어디에 쓰이는 클래스인지 주석 부탁드려요
Recorder/SnapCarouselView.swift
Outdated
| let cdHeight: CGFloat = 300 | ||
|
|
||
| // 기록물 id, 곡제목, 가수명, 앨범커버 배열 예시 | ||
| let cds = [ |
There was a problem hiding this comment.
cd list가 추가되거나 삭제될 수 있으니까
var 로 수정하는게 좋을 것 같습니다.
Suggested change
| let cds = [ | |
| var cds = [ |
|
확인했습니다 |
1 similar comment
|
확인했습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: CdListView 파일 분리 및 쓸모 없는 파일 삭제
Feat: CdListView CD inner shadow 추가