Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write view(글 작성 뷰) 기기 대응 #44

Merged
merged 4 commits into from
Sep 24, 2022
Merged

Write view(글 작성 뷰) 기기 대응 #44

merged 4 commits into from
Sep 24, 2022

Conversation

JIWON1923
Copy link
Member

Keychanges

  • mainView와 마찬가지로 scale 지정이 필요합니다.
  • 네비게이션 바의 두께 때문에 iPhoneSE(iPhone8)에서는 화면의 여백이 매우 적어지는 이슈가 존재합니다.

Screenshots

iPhone14 Pro iPhone13, 화면이름 iPhoneSE, 화면이름

@JIWON1923 JIWON1923 self-assigned this Sep 23, 2022
@JIWON1923 JIWON1923 added the 🌟 enhancement New feature or request label Sep 23, 2022
@JIWON1923 JIWON1923 added this to In progress in Second Sprint via automation Sep 23, 2022
@JIWON1923 JIWON1923 added this to the Record version1.0.0 milestone Sep 23, 2022
@JIWON1923 JIWON1923 changed the title Write view/auto layout Write view(글 작성 뷰) 기기 대응 Sep 23, 2022
mxnxxii
mxnxxii approved these changes Sep 24, 2022
View reviewed changes
Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SE로 봤을때, 여백이 줄어드는건 Se용 Hi-fi를 만들어서 사이즈 조정이 필요할 것 같습니다 :D (개인의견)

JMM00
JMM00 approved these changes Sep 24, 2022
View reviewed changes
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~!

@JIWON1923 JIWON1923 merged commit 812ce36 into develop Sep 24, 2022
Second Sprint automation moved this from In progress to Done Sep 24, 2022
@JIWON1923 JIWON1923 deleted the WriteView/AutoLayout branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM00 JMM00 JMM00 approved these changes

@mxnxxii mxnxxii mxnxxii approved these changes

@YunSeok-Choi YunSeok-Choi Awaiting requested review from YunSeok-Choi

@Eunbi-Cho Eunbi-Cho Awaiting requested review from Eunbi-Cho

Assignees

@JIWON1923 JIWON1923

Labels
🌟 enhancement New feature or request
Projects
No open projects
Second Sprint
Done
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JIWON1923 @JMM00 @mxnxxii