Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding 뷰 기기대응 #51

Merged
merged 8 commits into from
Sep 25, 2022
Merged

Onboarding 뷰 기기대응 #51

merged 8 commits into from
Sep 25, 2022

Conversation

JIWON1923
Copy link
Member

Keychanges

  • 온보딩뷰 기기 대응

Screenshots

1. iPhone 13, iOS16

iPhone13.16.mp4

2. iPhone 14 Pro Max, iOS16

iPhone14ProMax.mp4

3. iPhone SE, iOS 16

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2022-09-25.at.19.00.03.mp4

4. iPhone 13, iOS 15.5

Simulator.Screen.Recording.-.iPhone.13.-.2022-09-25.at.19.19.50.mp4

To Reviewer

  • 기존 모든 화면을 이미지로 삽입하였을 때, iPhoneSE나 iPhone Pro Max 등에서 사용하기 위해 모든 뷰를 이미지로 만들어야한다 판단했습니다.
  • 이에 각 컴포넌트들을 뷰에 배치하는 방식으로 구성하였습니다.
    • 스크린 사이즈에 따라 이미지의 크기를 변경하는 방식으로 적용했습니다.
    • 동일한 방식으로 모든 뷰에 해당 코드를 삽입하고자합니다!
    • 더 효율적인 방법을 알고 계시거나, 개선사항 있으면 코드리뷰 탭이나 댓글로 알려주시면 적용해보겠습니다!!
  • 최종 마지막 화면은 다음과 같습니다. (음악 기록가의 색상을 HiFi에 맞추어 작업하였습니다.)

@JIWON1923 JIWON1923 added the 🌟 enhancement New feature or request label Sep 25, 2022
@JIWON1923 JIWON1923 added this to the Record version1.0.0 milestone Sep 25, 2022
@JIWON1923 JIWON1923 self-assigned this Sep 25, 2022
@JIWON1923 JIWON1923 added this to In progress in Second Sprint via automation Sep 25, 2022
Copy link
Collaborator

@YunSeok-Choi YunSeok-Choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!! 👍👍

Comment on lines +18 to +26
let text: Text = {
var t = Text("음악 기록가")
.foregroundColor(.pointBlue)
.font(Font.customTitle2())
t = t + Text("가 되신 것을\n환영합니다.")
.foregroundColor(.titleBlack)
.font(Font.customTitle2())
return t
}()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 Swift 고수?!?!

Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~~!!

@JMM00 JMM00 merged commit fbea7c6 into develop Sep 25, 2022
Second Sprint automation moved this from In progress to Done Sep 25, 2022
@JIWON1923 JIWON1923 deleted the Onboarding/AutoLayout branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants