Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Record detail view 기기 대응 및 이미지 저장 기능 업데이트 #55

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

JMM00
Copy link
Member

@JMM00 JMM00 commented Sep 25, 2022

Keychanges

  • RecordDetailView 기기 대응
  • 이미지 저장 기능을 이미지 공유 기능으로 변경

Screenshots

기기대응

iPhone13, RecordDetailView iPhoneSE, RecordDetailView

이미지 공유

iPhone13,메뉴 iPhone13, action sheet iPhone13, 저장된 이미지

To Reviewer

다른 앱으로 공유 시 저장된 이미지의 형태로 공유됩니다. 이미지 저장 비율을 바꾸는게 좋을까요? 세로가 조금 부족해보이는 느낌이 있어서요..

@JMM00 JMM00 added the 🌟 enhancement New feature or request label Sep 25, 2022
@JMM00 JMM00 added this to In progress in Second Sprint via automation Sep 25, 2022
@JMM00 JMM00 changed the title Record detail view/auto layout [Feat] Record detail view 기기 대응 및 이미지 저장 기능 업데이트 Sep 25, 2022
Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지 비율을 바꾸는게 조금 더 보기 좋을 것 같아요 :D

@JMM00
Copy link
Member Author

JMM00 commented Sep 25, 2022

이정도 비율이면 괜찮을까요?

@mxnxxii
Copy link
Collaborator

mxnxxii commented Sep 25, 2022

이정도 비율이면 괜찮을까요?

좋아요 :D

@JIWON1923 JIWON1923 self-assigned this Sep 25, 2022
@JMM00 JMM00 removed the request for review from JIWON1923 September 25, 2022 15:59
Model/Screenshot.swift Show resolved Hide resolved
Record/RecordDetailView.swift Show resolved Hide resolved
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 이미지 공유 기능도 완성이군요! 👍🏻 코드가 깔끔해서 이해하기 좋았어요 :)

Model/Screenshot.swift Show resolved Hide resolved
@YunSeok-Choi YunSeok-Choi merged commit 9c14322 into develop Sep 27, 2022
Second Sprint automation moved this from In progress to Done Sep 27, 2022
@JIWON1923 JIWON1923 deleted the RecordDetailView/AutoLayout branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants