[Feat] #38 - Snap carousel view에서 cd 선택 방식 수정 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eunbi-Cho
changed the title
1 task
mxnxxii
approved these changes
Sep 27, 2022
JIWON1923
approved these changes
Sep 27, 2022
| @@ -73,13 +73,13 @@ struct Carousel<Items : View> : View { | |||
| }.onEnded { value in | |||
| self.UIState.screenDrag = 0 | |||
| // 뒤로 스크롤 | |||
| if (value.translation.width < -10 && CGFloat(self.UIState.activeCard) < numberOfItems - 1) { | |||
| if (value.translation.width < -5 && CGFloat(self.UIState.activeCard) < numberOfItems - 1) { | |||
| VStack { | ||
| Carousel( | ||
| numberOfItems: CGFloat(items.count), | ||
| spacing: spacing, | ||
| widthOfHiddenCds: widthOfHiddenCds | ||
| ){ | ||
| ) { |
| @@ -46,138 +44,106 @@ struct SnapCarousel: View { | |||
| Text(items[content].artist!) | |||
| .foregroundColor(Color.titleDarkgray) | |||
| .font(Font.customBody2()) | |||
| .padding(.bottom, 30) | |||
| .padding(.bottom, UIScreen.getHeight(20)) | |||
| } | ||
| .transition(AnyTransition.slide) | ||
| .animation(.spring()) | ||
| .animation(.spring(), value: UIState.activeCard) |
There was a problem hiding this comment.
버전 대응이 되었군요~!
덕분에 더 좋은 앱이 되었네요ㅎㅎ
Comment on lines
+82
to
+110
| VStack { | ||
| Text("CD를 선택하고 플레이어를 재생해보세요") | ||
| .foregroundColor(.titleGray) | ||
| .font(.customBody2()) | ||
| .frame(width: 300) | ||
| .padding(.bottom, -20) | ||
| .padding(.top, UIScreen.getHeight(45)) | ||
| ZStack { | ||
| Image("ListViewCdPlayer") | ||
| .offset(y: 30) | ||
|
|
||
| //MARK: - cdPlayer 안의 CD | ||
| ForEach(items.indices, id: \.self) { content in | ||
| if content == UIState.activeCard { | ||
| NavigationLink(destination: | ||
| RecordDetailView(item: items[content]), | ||
| isActive: $showDetailView) { // 상세 뷰로 이동 | ||
| URLImage(urlString: items[content].albumArt!) | ||
| .clipShape(Circle()) | ||
| .frame(width: 110, height: 110) | ||
| .rotationEffect(.degrees(self.angle)) | ||
| .animation(.timingCurve(0, 0.8, 0.2, 1, duration: 10), value: angle) | ||
| .onTapGesture { | ||
| self.angle += Double.random(in: 1000..<1980) | ||
| timeCount() | ||
| } | ||
| .padding(.bottom, 120) | ||
| .padding(.leading, 2) // CdPlayer를 그림자 포함해서 뽑아서 전체 CdPlayer와 정렬 맞추기 위함 | ||
| } |
There was a problem hiding this comment.
frame, padding에 기기대응 코드를 설정하면 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keychanges
Screenshots
To Reviewer