Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

기기대응, 메인화면 및 텍스트 크기 지정 #57

Merged
merged 2 commits into from
Sep 27, 2022
Merged

기기대응, 메인화면 및 텍스트 크기 지정 #57

merged 2 commits into from
Sep 27, 2022

Conversation

JIWON1923
Copy link
Member

Keychanges

  • 기기 별 텍스트 크기의 비율을 조절하였습니다.
    • 기기에서 크기가 적절한지 확인 후 수정이 필요합니다.
  • 메인 화면의 이미지 크기를 조절하였습니다.

Screenshots

iPhone13, iOS 16 iPhoneSE, iOS 16 iPhone 14 Pro Max, iOS 16

@JIWON1923 JIWON1923 added the 🌟 enhancement New feature or request label Sep 27, 2022
@JIWON1923 JIWON1923 self-assigned this Sep 27, 2022
@JIWON1923 JIWON1923 added this to In progress in Second Sprint via automation Sep 27, 2022
mxnxxii
mxnxxii approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자랑하는것처럼 짱 예뻐졌네요~

@JIWON1923 JIWON1923 added this to the Record version1.0.0 milestone Sep 27, 2022
YunSeok-Choi
YunSeok-Choi approved these changes Sep 27, 2022
View reviewed changes
Extension.swift
return Font.system(size: 13 * setSize(), weight: .regular)
}

static func setSize() -> Double {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 View 크기랑 같이 enum으로 관리해 주면 좋을 것 같아요!

@JIWON1923 JIWON1923 merged commit 747abf0 into develop Sep 27, 2022
Second Sprint automation moved this from In progress to Done Sep 27, 2022
@JIWON1923 JIWON1923 deleted the MainView/AutoLayout branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunSeok-Choi YunSeok-Choi YunSeok-Choi approved these changes

@mxnxxii mxnxxii mxnxxii approved these changes

@JMM00 JMM00 Awaiting requested review from JMM00

@Eunbi-Cho Eunbi-Cho Awaiting requested review from Eunbi-Cho

Assignees

@JIWON1923 JIWON1923

Labels
🌟 enhancement New feature or request
Projects
No open projects
Second Sprint
Done
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JIWON1923 @YunSeok-Choi @mxnxxii