RecordResultView, RecordDetailView #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment: 주석 수정 및 추가
unnnyong
reviewed
Jun 14, 2022
Recorder/RecordDetailView.swift
Outdated
| Image("backwindow") | ||
| }.padding(.top, 70.0) | ||
| Spacer() | ||
| } // BackgroundView용 VStack End |
There was a problem hiding this comment.
추후 Background 디자인 수정이 있을 가능성을 염두에 두고 Stack을 쉽게 구분하기 위해서 달아놓은 주석입니다. 삭제해도 무방한 주석은 달지 않는 것이 좋을까요?
There was a problem hiding this comment.
. 삭제해도 무방한 주석은 달지 않는 것이 좋을까요?
넵 ! 사실 주석없이 바로 이해할 수 있는 코드가 최고예요
네이밍이 필요하다면 해당 부분을 @ViewBuilder 또는 struct로써 별도로 명명하는게 맞다고 생각해요
unnnyong
reviewed
Jun 14, 2022
Recorder/RecordDetailView.swift
Outdated
|
|
||
| struct RecordDetailView: View { | ||
|
|
||
| // let music: Music |
There was a problem hiding this comment.
아직 해당 property가 우선 적용되어야하는 앞선 view들이 아직 구현되지 않아, 주석처리 되었습니다. view들을 합치는 과정에서 활성화될예정입니다.
이런 경우에는 주석처리말고 아예 이후에 기록하는 것이 좋을까요?
unnnyong
reviewed
Jun 14, 2022
Recorder/RecordDetailView.swift
Outdated
|
|
||
| HStack(alignment: .center) { | ||
|
|
||
| Button(action: {}, // action 내에 클릭시 모달을 통해 이미지 띄우는 기능 추가 예정 |
There was a problem hiding this comment.
Suggested change
| Button(action: {}, // action 내에 클릭시 모달을 통해 이미지 띄우는 기능 추가 예정 | |
| Button(action: {}, // TODO: action 내에 클릭시 모달을 통해 이미지 띄우는 기능 추가 예정 |
// TODO: 는 Xcode안에서 앞으로 해야할일을 작성할 때 사용해요 : )
There was a problem hiding this comment.
넵 해당 방식으로 작성하겠습니다
unnnyong
reviewed
Jun 14, 2022
Recorder/RecordResultView.swift
Outdated
Comment on lines
20
to
25
| Image(systemName: "chevron.backward") | ||
| Text("List") | ||
| } | ||
| ) | ||
| .foregroundColor(.pointBlue) | ||
| , |
There was a problem hiding this comment.
Re-Indent 대신 수동으로 줄바꿈 완료했습니다
Comment: 주석 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RecordResultView]
[RecordDetailView]