Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

런치스크린 이슈 #62

Merged
merged 2 commits into from
Sep 30, 2022
Merged

런치스크린 이슈 #62

merged 2 commits into from
Sep 30, 2022

Conversation

JIWON1923
Copy link
Member

@JIWON1923 JIWON1923 commented Sep 27, 2022 •
edited
Loading

Keychanges

  • 런치스크린이 이미지로 저장되어 iPhone 13 이외 기기에서 예상치 못한 이슈가 발생했습니다. -> safe area 보시면 됩니다~
  • storyboard를 이용하여 런치스크린을 제작하였습니다.

Screenshots

iPhone14 Pro Max, before iPhone14 Pro Max, after

To Reviewer

  • Launch Screen을 브랜딩으로 사용하는 것이 좋지 않다는 견해가 있는 것으로 알고 있는데, 여러분들의 생각은 어떤지 궁금하네요~!

@JIWON1923 JIWON1923 added the 🐛 bug Something isn't working label Sep 27, 2022
@JIWON1923 JIWON1923 added this to the Record version1.0.0 milestone Sep 27, 2022
@JIWON1923 JIWON1923 self-assigned this Sep 27, 2022
@JIWON1923 JIWON1923 added this to In progress in Second Sprint via automation Sep 27, 2022
@JMM00
Copy link
Member

JMM00 commented Sep 28, 2022

저는 런치스크린을 보여주기 위해서 일부러 지연시간을 넣는 경우가 아니라면 사용하는 것이 좋다고 생각합니다. 오히려 빈페이지가 앱이 제대로 실행되지 않는다는 느낌을 줄 것 같아요~!

JMM00
JMM00 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@JMM00 JMM00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

safe area까지 배경색이 통일되어서 훨씬 깔끔해 보여서 좋은 것 같아요!! 수고하셨습니다~!

Eunbi-Cho
Eunbi-Cho approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HIG에 따르면 Launch Screen은 '앱의 첫 번째 화면과 거의 동일한 시작 화면을 디자인합니다.' 라고 하네요!
쏘이 말처럼 로고를 활용한 브랜딩에 사용하는 것을 지양하고 있긴해요!
저희는 온보딩화면과 앱의 메인 화면 두가지 모두 방 이미지가 들어가서 추후에 방 배경으로 온보딩 화면을 수정하면 HIG를 따를 수 있을 것 같아요.
그런데 지금도 자연스럽게 이어지는 이미지라서 (특히 배경색을 맞췄기 때문에) 지금의 런치 스크린도 괜찮다고 생각합니다!

스토리보드를 사용하셨군요!!
수고많으셨어요! 👍🏻

YunSeok-Choi
YunSeok-Choi approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@YunSeok-Choi YunSeok-Choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대부분의 앱들이 런치스크린을 브랜딩으로 사용하기 때문에 저는 괜찮다고 생각합니다!

@JIWON1923 JIWON1923 merged commit 1f2b199 into develop Sep 30, 2022
Second Sprint automation moved this from In progress to Done Sep 30, 2022
@JIWON1923 JIWON1923 deleted the LaunchScreen branch September 30, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM00 JMM00 JMM00 approved these changes

@YunSeok-Choi YunSeok-Choi YunSeok-Choi approved these changes

@Eunbi-Cho Eunbi-Cho Eunbi-Cho approved these changes

@mxnxxii mxnxxii Awaiting requested review from mxnxxii

Assignees

@JIWON1923 JIWON1923

Labels
🐛 bug Something isn't working
Projects
No open projects
Second Sprint
Done
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JIWON1923 @JMM00 @YunSeok-Choi @Eunbi-Cho