Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapCarouselVIew - 노래 제목 및 가수 텍스트 프레임 지정 #63

Merged
merged 2 commits into from
Sep 29, 2022
Merged

SnapCarouselVIew - 노래 제목 및 가수 텍스트 프레임 지정 #63

merged 2 commits into from
Sep 29, 2022

Conversation

JIWON1923
Copy link
Member

@JIWON1923 JIWON1923 commented Sep 28, 2022 •
edited
Loading

Keychanges

  • 노래 제목이 길 때, cd 사이즈가 크게 주는 이슈를 해결하였습니다.

Screenshots

before, 여러줄 제목 after, 여러 줄 제목 한 줄 제목

To Reviewer

  • Marquee (텍스트가 흘러가는 것)으로 해결하고자 하였으나, 몇 이슈가 존재하여 우선 텍스트 프레임을 조절하는 방식으로 지정했습니다.
  • 해당 이슈는 discussions 탭에 올려두도록 하겠습니다!

@JIWON1923 JIWON1923 added the 🌟 enhancement New feature or request label Sep 28, 2022
@JIWON1923 JIWON1923 added this to the Record version1.0.0 milestone Sep 28, 2022
@JIWON1923 JIWON1923 self-assigned this Sep 28, 2022
@JIWON1923 JIWON1923 added this to In progress in Second Sprint via automation Sep 28, 2022
JMM00
JMM00 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2줄정도까지는 크게 영향을 주지 않는 것같아서 우선은 고정 텍스트로 제공하는 것도 충분히 좋은 것 같습니다
수고하셨습니다~!!!

Eunbi-Cho
Eunbi-Cho approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이제 잔나비 노래도 넣을 수 있군여,,, ㅎㅎ
frame으로 간단히 처리 가능하군요! 덕분에 긴 제목도 보기 좋아졌어요!!
수고많으셨습니다!

@JIWON1923 JIWON1923 merged commit 92dc375 into develop Sep 29, 2022
Second Sprint automation moved this from In progress to Done Sep 29, 2022
@JIWON1923 JIWON1923 deleted the SnapCarouselView/TextLength branch September 29, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM00 JMM00 JMM00 approved these changes

@Eunbi-Cho Eunbi-Cho Eunbi-Cho approved these changes

@YunSeok-Choi YunSeok-Choi Awaiting requested review from YunSeok-Choi

@mxnxxii mxnxxii Awaiting requested review from mxnxxii

Assignees

@JIWON1923 JIWON1923

Labels
🌟 enhancement New feature or request
Projects
No open projects
Second Sprint
Done
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JIWON1923 @JMM00 @Eunbi-Cho