Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detail View - 이미지 작성 모달 뷰 위치 수정 #65

Merged
merged 5 commits into from
Sep 30, 2022

Conversation

JIWON1923
Copy link
Member

Keychanges

  • 이미지 작성 모달 뷰 위치 수정

Screenshots

iPhoneSE

수정 전, DetailView 수정 후, DetailView WriteView

iPhone13

수정 후 DetailView WriteView

To Reviewer

  • WriteView에만 offset이 적용되어있었습니다.
  • UIScreen.getWidth를 이용하여 WriteView, DetailView 모두 동일하게 적용하였습니다.

@JIWON1923 JIWON1923 added the 🌟 enhancement New feature or request label Sep 28, 2022
@JIWON1923 JIWON1923 added this to the Record version1.0.0 milestone Sep 28, 2022
@JIWON1923 JIWON1923 self-assigned this Sep 28, 2022
@JIWON1923 JIWON1923 added this to In progress in Second Sprint via automation Sep 28, 2022
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~! 배열이 좀 더 조화로워진 것 같아서 좋아요!
그런데 혹시 아이폰 13에서 하단 여백이 눈에 띄는데 화면 크기별로 padding값을 다르게 주는 것은 어려울까요?

Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 눈치채지 못했던 부분인데 잡아주시다니!
눈에 자📐가 있으시군요

@JIWON1923
Copy link
Member Author

JIWON1923 commented Sep 30, 2022

확인했습니다~! 배열이 좀 더 조화로워진 것 같아서 좋아요!
그런데 혹시 아이폰 13에서 하단 여백이 눈에 띄는데 화면 크기별로 padding값을 다르게 주는 것은 어려울까요?

  • 현 시점에서는 뷰의 Stack 구조를 바꾸고, padding 값을 주는 것이 최선으로 보입니다!
  • 하단 뷰가 더 나은 것 같다면, 변경 사항 푸쉬 올릴게요~!
  • 달라진게 없다고 느껴지시는건 다 착각입니다🥕
iPhone13 iPhoneSE iPhone14 Pro Max

Copy link
Collaborator

@YunSeok-Choi YunSeok-Choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 디테일까지.,,, 역시 디발자시군요..!

Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

당신은 못하는게 뭐죠? 미쳤네요

@JIWON1923 JIWON1923 merged commit bf20470 into develop Sep 30, 2022
Second Sprint automation moved this from In progress to Done Sep 30, 2022
@JIWON1923 JIWON1923 deleted the DetailView/ViewPosition branch September 30, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants