Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] SearchView 키보드 포커스 기능 추가 #66

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

JMM00
Copy link
Member

@JMM00 JMM00 commented Sep 29, 2022

Keychanges

  • SearchView 접근 시 키보드 포커스 기능 추가

Screenshots

iPhone8

Simulator.Screen.Recording.-.iPhone.8.-.2022-09-29.at.14.03.05.mp4

iPhone13

Simulator.Screen.Recording.-.iPhone.13.-.2022-09-29.at.14.03.12.mp4

To Reviewer

  • 약간의 딜레이 (0.5초) 후 키보드가 올라오는데 이부분이 어색한지 궁금합니다

@JMM00 JMM00 added the 🌟 enhancement New feature or request label Sep 29, 2022
@JMM00 JMM00 self-assigned this Sep 29, 2022
@JMM00 JMM00 added this to In progress in Second Sprint via automation Sep 29, 2022
@JMM00 JMM00 removed this from In progress in Second Sprint Sep 29, 2022
@JMM00 JMM00 added this to In progress in Second Sprint via automation Sep 29, 2022
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

덕분에 더 유저친화적인 앱이 된 것 같아요!!
빈 화면을 키보드가 알뜰히 채워주는 것 같습니다!
0.5초 딜레이는 저는 오히려 애니메이션 효과처럼 자연스럽게 느껴져요!
수고 많으셨어요~!👍🏻

@JMM00 JMM00 changed the title [Feat]: #48 - SearchView 접근 시 키보드 포커스 기능 추가 [Feat]: SearchView 키보드 포커스 기능 추가 Sep 29, 2022
@JMM00 JMM00 changed the title [Feat]: SearchView 키보드 포커스 기능 추가 [Feat] SearchView 키보드 포커스 기능 추가 Sep 29, 2022
Copy link
Member

@JIWON1923 JIWON1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.5초 딜레이 저도 괜찮아보여요~!

Record/SearchView.swift Show resolved Hide resolved
Record/SearchView.swift Show resolved Hide resolved
Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오히려 의도한 애니메이션같이 느껴지고 좋아요~!

@JMM00 JMM00 merged commit aa48ade into develop Sep 30, 2022
Second Sprint automation moved this from In progress to Done Sep 30, 2022
@JIWON1923 JIWON1923 deleted the SearchView/emptyUI_ver2 branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants