Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] action sheet header 설명 추가 #67

Merged
merged 4 commits into from
Sep 30, 2022
Merged

[Feat] action sheet header 설명 추가 #67

merged 4 commits into from
Sep 30, 2022

Conversation

JMM00
Copy link
Member

@JMM00 JMM00 commented Sep 29, 2022

Keychanges

  • 공유 액션 시트에 'RE:CORD', '노래제목-아티스트' 설명 추가

Screenshots

iPhone13, 화면이름 iPhoneSE, 화면이름

To Reviewer

  • 인스타그램 게시글로 공유 시 모달창 에러납니다. 기본 사진어플에서 공유 시 동일한 오류가 발생되는 것으로 보아 인스타그램 자체 오류인 것 같습니다. (스토리나 메세지 전송은 정상적으로 잘 됩니다.)
  • 카카오톡으로 공유 시 사진과 '노래제목-아티스트' 텍스트가 같이 공유됩니다.

@JMM00 JMM00 added the 🌟 enhancement New feature or request label Sep 29, 2022
@JMM00 JMM00 added this to the Record version1.0.0 milestone Sep 29, 2022
@JMM00 JMM00 self-assigned this Sep 29, 2022
@JMM00 JMM00 added this to In progress in Second Sprint via automation Sep 29, 2022
@JMM00 JMM00 removed this from In progress in Second Sprint Sep 29, 2022
@JMM00 JMM00 added this to In progress in Second Sprint via automation Sep 29, 2022
Eunbi-Cho
Eunbi-Cho approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LinkPresentation 코드는 처음 보는데 이런식으로 사용할 수 있군요!
덕분에 많이 배워갑니다~!
제목과 가수까지 뜨는 것 너무 좋아요!
수고많으셨어요!

Eunbi-Cho
Eunbi-Cho approved these changes Sep 29, 2022
View reviewed changes
Record/RecordDetailView.swift Show resolved Hide resolved
@JMM00 JMM00 changed the title Record detail view/add action sheet header [Feat] action sheet header 설명 추가 Sep 29, 2022
mxnxxii
mxnxxii approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오옹 좋아요 좋아요 〰 !!

@JMM00 JMM00 merged commit 382771b into develop Sep 30, 2022
Second Sprint automation moved this from In progress to Done Sep 30, 2022
@JIWON1923 JIWON1923 deleted the RecordDetailView/AddActionSheetHeader branch October 3, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eunbi-Cho Eunbi-Cho Eunbi-Cho approved these changes

@mxnxxii mxnxxii mxnxxii approved these changes

@YunSeok-Choi YunSeok-Choi Awaiting requested review from YunSeok-Choi

@JIWON1923 JIWON1923 Awaiting requested review from JIWON1923

Assignees

@JMM00 JMM00

Labels
🌟 enhancement New feature or request
Projects
No open projects
Second Sprint
Done
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JMM00 @Eunbi-Cho @mxnxxii