Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #47 - SearchView List BackgroundColor 배경색으로 바꿈 #68

Merged
merged 2 commits into from
Sep 30, 2022
Merged

[Feat] #47 - SearchView List BackgroundColor 배경색으로 바꿈 #68

merged 2 commits into from
Sep 30, 2022

Conversation

Eunbi-Cho
Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho commented Sep 29, 2022 •
edited
Loading

Keychanges

  • SearchView List BackgroundColor를 배경색으로 바꿨습니다.

Screenshots

iPhone13, SearchView iPhoneSE, SearchView
Simulator Screen Recording - iPhone 13 - 2022-09-30 at 01 13 44 Simulator Screen Recording - iPhone SE (3rd generation) - 2022-09-30 at 01 13 21

To Reviewer

  • listRowBackground 컬러를 배경색으로 바꿨는데, 리스트 자체가 흰색이어서 스크롤을 하면 흰 배경이 보입니다!
  • .scrollContentBackground(.hidden)을 쓰면 리스트 배경색을 바꿀수 있는데, iOS16에만 적용가능한 코드더라구요 ㅠㅠ
  • 다른 방법은 써도 적용이 안되는데, 혹시 다른 아이디어가 있으시면 알려주세요...!

@Eunbi-Cho Eunbi-Cho added this to the Record version1.0.0 milestone Sep 29, 2022
@Eunbi-Cho Eunbi-Cho added this to In progress in Second Sprint via automation Sep 29, 2022
@Eunbi-Cho Eunbi-Cho self-assigned this Sep 29, 2022
@Eunbi-Cho Eunbi-Cho added the 🌟 enhancement New feature or request label Sep 29, 2022
mxnxxii
mxnxxii reviewed Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금 올라와있는 친구들은 iOS 몇버전일까요 〰 ?

@Eunbi-Cho
Copy link
Collaborator Author

위에 올라온 아이들은 시뮬레이터에서 캡쳐한 거라 iOS 16 이전 버전이네요!
캐치 감사해용 :)

iOS 16도 확인 완료했습니다!

RPReplay_Final1664548188.mov

JIWON1923
JIWON1923 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@JIWON1923 JIWON1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다음 스프린트에 더 낮은 버전도 사용가능하도록 지원하면 좋을 것 같네요~

@JIWON1923
Copy link
Member

다음 스프린트에 더 낮은 버전도 사용가능하도록 지원하면 좋을 것 같네요~

안나가 inset 모드를 사용한 이유를 잘 이해해 주셨네요~!
버전 대응은 다음 스프린트에서 진행해도 좋을 것 같아요!

JMM00
JMM00 approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리스트 외관 배경색을 맞춰서 통일성을 줘서 충분히 예뻐졌다고 생각합니다~! 리스트 배경색은 버전별 대응 방법을 찾아서 추후 업데이트 하면 더 좋을 것 같아요 수고하셨습니다~~!!

@JIWON1923 JIWON1923 merged commit 05c6a65 into develop Sep 30, 2022
@JIWON1923 JIWON1923 deleted the SearchView/ChangeListBackgroundColor branch September 30, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxnxxii mxnxxii mxnxxii left review comments

@JMM00 JMM00 JMM00 approved these changes

@JIWON1923 JIWON1923 JIWON1923 approved these changes

@YunSeok-Choi YunSeok-Choi Awaiting requested review from YunSeok-Choi

Assignees

@Eunbi-Cho Eunbi-Cho

Labels
🌟 enhancement New feature or request
Projects
No open projects
Second Sprint
In progress
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eunbi-Cho @JIWON1923 @JMM00 @mxnxxii