RecordDetailView #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feat: DetailView 상에 Menu 추가
|
확인했습니다. |
|
확인완료! |
|
확인했습니다 |
|
확인했습니다! |
JIWON1923
reviewed
Jun 15, 2022
| @@ -14,6 +15,25 @@ struct RecordDetailView: View { | |||
| ZStack { | |||
| Color.background.edgesIgnoringSafeArea(.all) | |||
| RecordBackground() | |||
| VStack { | |||
There was a problem hiding this comment.
전체적으로 인텐트 맞춰주시면 가독성이 좋아질 것 같아요
| Spacer() | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
다른 파일에서도 사용하는 뷰라면, 새로운 Swift파일을 만들어서 관리하는게 좋을 것 같아요
There was a problem hiding this comment.
그럼 이부분은 이번 머지 이후 따로 UIView를 생성해서 코드를 옮겨놓도록 하겠습니다
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Style: UI offset 조정
Feat: DetailView 상에 Menu 추가
RecordResultView 상의 NavigationView는 삭제 예정입니다. 우선은 UI변경 체크