Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #75 검색 결과 초기화 #81

Merged
merged 2 commits into from
Nov 13, 2022
Merged

[Feat] #75 검색 결과 초기화 #81

merged 2 commits into from
Nov 13, 2022

Conversation

JMM00
Copy link
Member

@JMM00 JMM00 commented Nov 8, 2022

Keychanges

  • SearchView에서 검색 > HomeView > SearchView로 접근 시 화면에 남아있는 검색 결과 리스트를 초기화하는 기능을 추가했습니다.

Screenshots

Simulator.Screen.Recording.-.iPhone.14.-.2022-11-08.at.23.28.17.mp4

To Reviewer

  • Bool값을 하나 추가하여 다른 화면에서 navigationlink로 접근하는 경우와 뒤로가기로 접근하는 경우를 구분해서 결과 리스트를 초기화하도록 했습니다.

@JMM00 JMM00 added the 🌟 enhancement New feature or request label Nov 8, 2022
@JMM00 JMM00 added this to the Record version1.0.0 milestone Nov 8, 2022
@JMM00 JMM00 added this to In progress in v1.0.1 via automation Nov 8, 2022
@JMM00 JMM00 self-assigned this Nov 8, 2022
JIWON1923
JIWON1923 approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@JIWON1923 JIWON1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
조건문으로 간단히 해결할 수 있군요👍

v1.0.1 automation moved this from In progress to Reviewer approved Nov 13, 2022
@JIWON1923 JIWON1923 changed the base branch from main to develop November 13, 2022 20:09
@JIWON1923 JIWON1923 merged commit eb72d36 into develop Nov 13, 2022
v1.0.1 automation moved this from Reviewer approved to Done Nov 13, 2022
@JIWON1923 JIWON1923 deleted the SearchView/ResetList branch November 13, 2022 20:15
@JIWON1923 JIWON1923 mentioned this pull request Feb 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JIWON1923 JIWON1923 JIWON1923 approved these changes

@Eunbi-Cho Eunbi-Cho Awaiting requested review from Eunbi-Cho

@YunSeok-Choi YunSeok-Choi Awaiting requested review from YunSeok-Choi

Assignees

@JMM00 JMM00

Labels
🌟 enhancement New feature or request
Projects
v1.0.1
Done
Milestone
Record version1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JMM00 @JIWON1923