Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #71 - 저장되는 이미지를 png에서 jpeg로 변경 #84

Merged
merged 1 commit into from
Feb 4, 2023
Merged

[Fix] #71 - 저장되는 이미지를 png에서 jpeg로 변경 #84

merged 1 commit into from
Feb 4, 2023

Conversation

Eunbi-Cho
Copy link
Collaborator

Keychanges

  • 4:3 비율의 사진이 저장되면 이미지가 회전하는 이슈가 있었음
  • png로 저장되던 이미지를 jpeg로 변경하니 이미지가 회전하지 않음

Screenshots

IMB_Ds5yuc

@Eunbi-Cho Eunbi-Cho added the 🐛 bug Something isn't working label Nov 21, 2022
@Eunbi-Cho Eunbi-Cho self-assigned this Nov 21, 2022
YunSeok-Choi
YunSeok-Choi approved these changes Nov 23, 2022
View reviewed changes
Copy link
Collaborator

@YunSeok-Choi YunSeok-Choi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와우 이렇게 간단하게!! 최고다...

JIWON1923
JIWON1923 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@JIWON1923 JIWON1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와...!!! LGTM
감탄만 남기고 갑니다👍
오류 원인도 찾기 힘드셨을텐데 고생하셨습니다.

@JIWON1923
Copy link
Member

#87

UIImage가 4:3 비율일 때, orientation이 3으로 설정되더라고요!
pngData()의 경우 orientation을 신경쓰지 않고 그냥 바로 데이터로 변환하고, jpenData()의 경우 orientation을 재설정 한 후 저장하는 것 같습니다!

저희 앱의 경우 jpeg로 저장하는 것이 적절하지만, 여러분이 다른 프로젝트 하실 때 image orientation에 따라 처리하는 방법이 필요할 것 같아 공유드립니다!

@Eunbi-Cho Eunbi-Cho linked an issue Jan 29, 2023 that may be closed by this pull request
[Fix] cdListView 이미지 회전 이슈 #71
Closed
JMM00
JMM00 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하고 빠른 해결 최고에요~~!!

@JIWON1923 JIWON1923 merged commit fd27a10 into develop Feb 4, 2023
@JIWON1923 JIWON1923 deleted the writeView/fixImageRotateBug branch February 4, 2023 05:40
@JIWON1923 JIWON1923 mentioned this pull request Feb 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JMM00 JMM00 JMM00 approved these changes

@YunSeok-Choi YunSeok-Choi YunSeok-Choi approved these changes

@JIWON1923 JIWON1923 JIWON1923 approved these changes

Assignees

@Eunbi-Cho Eunbi-Cho

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] cdListView 이미지 회전 이슈
4 participants
@Eunbi-Cho @JIWON1923 @JMM00 @YunSeok-Choi