Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #83 DetailView 편집 후 뷰 리프레시 안됨 수정 #85

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

YunSeok-Choi
Copy link
Collaborator

Keychanges

  • DetailView에서 작성한 뷰를 편집하고 저장시 바로 반영되지 않던 버그를 수정하였습니다.

Screenshots

iPhone13, DetailView

To Reviewer

  • 현재 저장되어 있는 사용자의 기록들이 변경될 시 변경된 내용으로 보일 수 있게 하였습니다.

@YunSeok-Choi YunSeok-Choi added the 🐛 bug Something isn't working label Dec 10, 2022
@YunSeok-Choi YunSeok-Choi self-assigned this Dec 10, 2022
@YunSeok-Choi YunSeok-Choi linked an issue Dec 10, 2022 that may be closed by this pull request
Copy link
Member

@JIWON1923 JIWON1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !! 융식 감사해요 덕분에 유저들이 더 직관적으로 사용할 수 있게 됐네요!!
suggestion 확인 한 번 부탁드립니다!

@@ -98,7 +98,7 @@ struct SnapCarousel: View {
ForEach(items.indices, id: \.self) { content in
if content == UIState.activeCard {
NavigationLink(destination:
RecordDetailView(item: items[content]),
RecordDetailView(item: $items[content]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binding으로 해결하셨군요 👍

Record/Views/DetailViews/RecordDetailView.swift Outdated Show resolved Hide resolved
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~! 바인딩으로 깔끔해 해결해주셨네요~! 좋아요~!!

Co-authored-by: Soi (Jiwon Lee) <zest1923@gmail.com>
@YunSeok-Choi YunSeok-Choi merged commit 9d9729b into develop Feb 2, 2023
@YunSeok-Choi YunSeok-Choi deleted the RecordDetailView/ReloadView branch February 2, 2023 14:47
@JIWON1923 JIWON1923 mentioned this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] DetailView 편집 후 뷰 리프레시 안됨
3 participants