Improvements and Simplifications to ThreadPool #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed type definition of thread pool for thread_pool_impl. Simplified class by removing queue template parameter. Switched to using std::deque for task_queue objects so that we don't have to use unique_ptrs for those objects. Made pool non-copyable. Enqueue parameters by value for version that returns a future. Removed other unused type definitions.
Fix to push function to properly use the lock guard before notifying with the condition variable. Switched to using std::deque directly instead of std::queue for the underlying data.
Renamed old test and added new test to ensure that work completes before the thread pool gets destroyed.
Added way to ensure that tasks complete before destroying the thread pool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements/changes largely based on feedback from Code Review and Reddit
Changed
typedefs(YAGNI)Queuetemplate parameter (also YAGNI)std::dequeinstead ofstd::queueindp::thread_safe_queuestd::dequeindp::thread_poolso that usage ofstd::unique_ptris no longer needed for internal task objects.Fixed
dp::thread_safe_queue's usage of lock guards before notifying threads of new data being available.