Fix issues with wait_for_tasks()
#68
Merged
+123
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jtd-formlabs
reviewed
Jul 3, 2024
jtd-formlabs
approved these changes
Jul 4, 2024
Use std::barrier with wait for tasks. This requires std::move_only_function to be available.
We suppress exceptions before enquing the task so it doesn't seem necessary to have try/catch when we invoke the enqueued task
DeveloperPaul123
force-pushed
the
fix/wait-for-tasks
branch
from
ac68c04
to
9b5486d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP fixes for #64 centered around bugs with the
wait_for_tasks()API. Thanks @jtd-formlabs for your help!