Feat: add button on domains page #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add button on the domains page that gets the user to new domain screen Closes #198
humphd
approved these changes
Feb 14, 2023
| @@ -31,6 +32,11 @@ export default function DomainsIndexRoute() { | |||
| been the industry's standard dummy text ever since the 1500s, when an unknown printer took a | |||
| galley of type and scrambled it to make a type specimen book. | |||
| </Text> | |||
| <Flex justifyContent="flex-end"> | |||
| <Link to="/domains/new"> | |||
| <Button rightIcon={<AddIcon boxSize={3} />}>Create new domain</Button> | |||
There was a problem hiding this comment.
I wonder if Domain (capital) is better? Not sure.
There was a problem hiding this comment.
We have other buttons on different page follow a capitalistic format for each word, maybe we can do the same thing here?
There was a problem hiding this comment.
I don't have a hard opinion on that, if you guts want I can change it to capital
There was a problem hiding this comment.
Same, we should just set a standard and stick with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add button on the domains page that gets the user to new domain screen
Closes #198