Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout is only our session logout #343

Merged
merged 3 commits into from Mar 15, 2023
Merged

Conversation

sfrunza13
Copy link
Contributor

@sfrunza13 sfrunza13 commented Mar 14, 2023

To be tested on staging, but I think this will only effect the starchart session.
closes #338

@sfrunza13 sfrunza13 requested a review from humphd March 14, 2023 22:47
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing to touch up. Thanks for fixing this.

app/routes/logout.tsx Outdated Show resolved Hide resolved
@sfrunza13 sfrunza13 requested a review from humphd March 15, 2023 01:26
humphd
humphd previously approved these changes Mar 15, 2023
app/routes/logout.tsx Outdated Show resolved Hide resolved
@sfrunza13 sfrunza13 merged commit f4a9b89 into DevelopingSpace:main Mar 15, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Logout to end Starchart session, but not do SLO
4 participants