Poll for pending records in UI until active or error #355
Conversation
app/routes/__index/domains/index.tsx
Outdated
| revalidator.revalidate(); | ||
| }, | ||
| pending ? 5_000 : null | ||
| ); | ||
|
|
||
| return ( | ||
| <Container maxW="contianer.xl"> |
There was a problem hiding this comment.
Not related to this PR, but we should file an issue to fix the spelling error in the value for maxW, so CSS rules can be applied as intended.
There was a problem hiding this comment.
Nice. I'll fix it here, since I'm in this file.
|
In this PR, will the newly created record ever change to 'active'? |
|
It should. When that happens depends on how long it takes for the DNS to finish. |
|
Shouldn't it be |
|
app/routes/__index/domains/index.tsx
Outdated
| const domains = useTypedLoaderData<typeof loader>(); | ||
| const pending = domains.some((domain) => domain.status === 'pending'); |
There was a problem hiding this comment.
Would be useMemo here applicable to avoid unnecessary UI re-renders?
There was a problem hiding this comment.
I don't think we need useMemo here, since we always want to be in sync with the value of `domains, and the cost of the calculation is cheap.
But I'll add and we can remove if it i's not working.
|
I had to rebase to update |
Fixes #316.
This change removes the manual update logic for a user's DNS Records, replacing it with automated polling based on the
statusof the records.When we display the table, we check to see if any of the records are
status === 'pending'(i.e., vs.activeorerror). If any arepending, we start an interval that runs every 5s, and recalls the loader to check for updates. Once thependingstatus is gone, we stop the interval.To test this:
name=issue316,type=A,value=192.168.2.1)I also cleaned up the ordering of the imports.