Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort user records in model #570

Merged
merged 1 commit into from Apr 12, 2023
Merged

Conversation

Genne23v
Copy link
Contributor

Resolve #442

I added orderBy instead of handling in frontend. I'm not sure if I'm missing something with this approach. Please let me know if there is any concern with this. Thanks

@Genne23v Genne23v added the category: data Anything related to data management and structure label Apr 11, 2023
@Genne23v Genne23v added this to the Milestone 1.0a milestone Apr 11, 2023
@Genne23v Genne23v requested a review from a user April 11, 2023 23:59
@Genne23v Genne23v self-assigned this Apr 11, 2023
@humphd humphd requested a review from cychu42 April 12, 2023 13:39
@cychu42
Copy link
Contributor

cychu42 commented Apr 12, 2023

The code looks right.
I'm just wondering if we want proper sorting, like letting users click a column to sort by that column, or this is all we want from that issue.

@cychu42
Copy link
Contributor

cychu42 commented Apr 12, 2023

I can see using this PR to set this ordering as the default behavior, and then add the sorting I mentioned in a different issue later.

@humphd humphd merged commit b0b0260 into DevelopingSpace:main Apr 12, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: data Anything related to data management and structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort DNS Records such that multiple records with same name are grouped
3 participants