New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remix depreciation warnings #614
Fix remix depreciation warnings #614
Conversation
Discussion on Slack: based on https://remix.run/docs/en/main/file-conventions/route-files-v2#nested-layouts-without-nested-urls, we think we should use |
a44365b
to
188a44f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semantically I think that using _auth makes sense because we have to be authenticated for everything to do with starchart. I like it.
bf4bb12
to
7f61405
Compare
Updated to fix the rest of the depreciation warnings + rebased with main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the error/catch boundary change too. This looks great.
Resolves #320
Fixed our remix depreciation warnings following their guide
Changes made
_index.tsx
to_auth.tsx
. This was needed because now the index routes are specified by_index.tsx
, and it was not possible to specify the index route's layout as_index.tsx
(Summary of v1 vs v2:
navigation.formMethod === "post";
should now benavigation.formMethod === "POST";
etc)CatchBoundry
andErrorBoundy
into oneErrorBoundry
for each file with checks to render different error layouts.CatchBoundry
no longer exists in v2