Handle bad OEmbed responses and return message #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When requesting an OEmbed object, handle the situation that the provider might return a non-successful response. In that case, have `oembed_data` return `nil` and keep the `figure div.embed` element empty.
When a requested OEmbed object returns an error, render a message for the user explaining that there was an error with the embedded element. For this, standardize the `OEbedResolver::Base#source_url` method and add a `#name` method which will be included in the text for the user. The text for the user will be rendered within the `<figure>` element within a nested `span` with the class `unavailable-embed`. This also allows the consumer to have custom CSS for this case.
nicolas-fricke
force-pushed
the
handle-oembed-bad-responses
branch
from
ef03d4e
to
82367fc
Compare
|
+1 |
dsager
approved these changes
Nov 7, 2017
towanda
approved these changes
Nov 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting an OEmbed object, handle the situation that the provider might return a non-successful response. In that case, render a message for the user explaining that there was an error with the embedded element.
For this, standardize the
OEbedResolver::Base#source_urlmethod and add a#namemethod which will be included in the text for the user.The text for the user will be rendered within the
<figure>element within a nestedspanwith the classunavailable-embed. This also allows the consumer to have custom CSS for this case.