Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement parsing of hashes #49

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Implement parsing of hashes #49

merged 1 commit into from
Sep 14, 2017

Conversation

dsager
Copy link
Member

@dsager dsager commented Sep 14, 2017

This allows to initialize the intermediate format from hashes, which are obtained by parsing json code.

The added integration test parses the json fixture and "jsonifies" it to make result and source are identical.

This looks quite big, but it a lot of repetition and tests. Sorry :)

This allows to initialize the intermediate format from hashes,
which are obtained by parsing json code.

The added integration test parses the json fixture and
"jsonifies" it to make result and source are identical.
@ifosch
Copy link
Member

ifosch commented Sep 14, 2017

+1

1 similar comment
@miguelbernadi
Copy link
Contributor

+1

@dsager dsager merged commit dcbb2f2 into Devex:master Sep 14, 2017
@dsager dsager deleted the html-export branch September 14, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants