Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

issue/7 Negative Bars #19

Merged
merged 2 commits into from
Jul 30, 2019
Merged

issue/7 Negative Bars #19

merged 2 commits into from
Jul 30, 2019

Conversation

zombiesplat
Copy link
Contributor

Adding ability for negative numbers
Adding a minimum bar height to avoid ugly math when
the value is zero

Adding ability for negative numbers
Adding a minimum bar height to avoid ugly math when
the value is zero
@zombiesplat zombiesplat mentioned this pull request Jul 21, 2019
@zombiesplat
Copy link
Contributor Author

So I just realized that the additional work I did last night for some other stuff is showing in this PR. If you get around to looking at this, and you like the changes, let me know and I'll fix my PR against the first commit.

@zombiesplat
Copy link
Contributor Author

Which btw, the more recent commit deals with the issue about labels.

@DeviaVir DeviaVir self-requested a review July 29, 2019 15:44
@DeviaVir
Copy link
Owner

https://jsfiddle.net/d3Lbnagc/
https://jsfiddle.net/d3Lbnagc/1/

Seems to work fine.

Thank you for contributing!

@DeviaVir DeviaVir merged commit 2375cff into DeviaVir:master Jul 30, 2019
@DeviaVir
Copy link
Owner

included in 0.1.5 release https://www.npmjs.com/package/vuebars

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants