Intermittent crashing when using Bittrex

[ToastMaster]

System information

• Have I written custom code (as opposed to using zenbot vanilla):

This is using zenbot vanilla

• OS Platform and Distribution (e.g., Linux Ubuntu 16.04):

ubuntu 16.04.3

• Zenbot version:

4.1.0

• NodeJS version:

8.9.0

• Python version:

2.7.12

• Exact command to reproduce:

./zenbot.sh trade bittrex.XRP-BTC --strategy rsi --period=1m --order_type=maker --currency_capital .03268881 --buy_pct 25 --order_adjust_time 10000 --order_poll_time 5000 --poll_trades 15000 --rsi_periods=20 --oversold_rsi=25 --overbought_rsi=70 --rsi_recover=5 --rsi_drop=5

Describe the problem

Describe the problem clearly here. Be sure to convey here why it's a bug in Zenbot or a feature request.

Occasionally, when using zenbot with Bittrex, it crashes. There does not appear to be time based, but pretty random.

Source code / logs

Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached. Try to provide a reproducible test case that is the bare minimum necessary to generate the problem.

This is the error message provided when it crashes:

/home/rivey/zenbot/extensions/exchanges/bittrex/exchange.js:113
if(!data.success) {
^

TypeError: Cannot read property 'success' of null
at /home/rivey/zenbot/extensions/exchanges/bittrex/exchange.js:113:18
at Request._callback (/home/rivey/zenbot/node_modules/node.bittrex.api/node.bittrex.api.js:127:11)
at self.callback (/home/rivey/zenbot/node_modules/request/request.js:186:22)
at emitOne (events.js:116:13)
at Request.emit (events.js:211:7)
at ClientRequest. (/home/rivey/zenbot/node_modules/request/request.js:785:18)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:106:13)
at ClientRequest.emit (events.js:208:7)
at TLSSocket.emitTimeout (_http_client.js:708:34)
at Object.onceWrapper (events.js:313:30)
at emitNone (events.js:106:13)
at TLSSocket.emit (events.js:208:7)
at TLSSocket.Socket._onTimeout (net.js:407:8)
at ontimeout (timers.js:475:11)
at tryOnTimeout (timers.js:310:5)
at Timer.listOnTimeout (timers.js:270:5)

[station384]

this is corrected in #1215 which is currently in the unstable branch.

[station384]

This error is addressed in unstable