This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
fix phenotype win loss ratio weighting #1251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heerpa
pushed a commit
to Heerpa/zenbot
that referenced
this pull request
Feb 25, 2018
This was referenced Mar 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current calculation in the phenotype fitness are incorrect. The
wlRatioisn't currently a ratio, but as the variable name suggests, it should be. The result being that the scaling forwlRatioRategoes properly from 0.5 for all losses compared to wins to 1.0 for all wins compared to losses.Since 0/0 in JS is
NaN, there's a special case for no trades made where it will set it to 1 (basically 1/1 ratio of wins to losses, even if both were zero).Also, Euler's number is a built-in mathematic constant in JS, so we can just use it since it's more precise.