This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Remove forex_analytics #1937
Merged
Remove forex_analytics #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Builds on Ubuntu aswell. |
|
@DeviaVir Also please review this. |
DeviaVir
approved these changes
Sep 25, 2019
|
Not sure what's up with node 8, doesn't seem related. |
olexiyb
pushed a commit
to olexiyb/zenbot
that referenced
this pull request
Feb 2, 2020
* Add fsevents dep, bump talib and tulind deps * Removal of forex_analytics
YarnSeemannsgarn
pushed a commit
to YarnSeemannsgarn/zenbot
that referenced
this pull request
Apr 15, 2020
* Add fsevents dep, bump talib and tulind deps * Removal of forex_analytics
|
@DeviaVir when update.sh is run, the default is to pull the master branch. I think this PR deserves to be in the master branch, can you please merge there too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is complete removal of forex_analytics which could be one solution to #1765.