This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add support for Gemini exchange platform #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We call this function with either a trade, or timestamp in the case of a backfill
Made some of the error reporting a bit prettier Fix incorrect use for the numbro 'format' method
…oper status and flags now Increase rate limit to 2000 after having some issues with backfilling
Updated the readme to add QCX and Gemini support
Closed
DeviaVir
approved these changes
Aug 7, 2017
|
Error: Cannot find module 'gemini-api' |
Fixed by running |
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Update developer document to address common bugs in getCursor * Fix bug with implementation of getCursor We call this function with either a trade, or timestamp in the case of a backfill * Quadriga - Fix bug with incorrect implementation of getCUrsor Made some of the error reporting a bit prettier Fix incorrect use for the numbro 'format' method * Kraken - Fix bug with the way rejected order were handle, pass the proper status and flags now Increase rate limit to 2000 after having some issues with backfilling * Add support for Gemini exchange Updated the readme to add QCX and Gemini support * I always forget to format before submitting * Forgot to stage conf-sample with Gemini updates * More formatting :)
This was referenced Jan 21, 2020
This was referenced Mar 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change principally add support for the Gemini exchange, including the option to switch between the live and sandbox environment. The API is tested via backfill, buy, sell, trade (live and paper in sandbox). Populated products and added an update script.
In the process of implementing the exchange I've identified and corrected a few other bugs and inconsistencies in other platforms along the way. Please note the updates to the developer documentation around subtleties in the way the getCursor function is used by the backfill command. If not implemented properly the
--daysoption may be ignored during the backfill.Also identified and corrected a bug in the way kraken reported rejected orders. It's possible that someone reported rejected orders as done to prevent re-posting of cancelled post-only market orders. Right now there is no option to enable or disable this feature in the engine. If this is the case, then the option should be added to allow users to choose between standard limit, or post-only orders.