This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Filter the simulation output from ansi-codes so that the results can … #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviaVir
approved these changes
Oct 3, 2017
| @@ -6,6 +6,7 @@ | |||
| "json2csv": "^3.7.3", | |||
| "round-precision": "^1.0.0", | |||
| "run-parallel-limit": "^1.0.3", | |||
| "shelljs": "^0.7.8" | |||
| "shelljs": "^0.7.8", | |||
| "strip-ansi": "^4.0.0" | |||
There was a problem hiding this comment.
you may also want to update package-lock.json in this directory:
rm -rf package-lock.json
npm i
git add . # etc etc
| @@ -8,6 +8,7 @@ | |||
| "round-precision": "^1.0.0", | |||
| "run-parallel-limit": "^1.0.3", | |||
| "shelljs": "^0.7.8", | |||
| "yargs": "^8.0.2" | |||
| "yargs": "^8.0.2", | |||
| "strip-ansi": "^4.0.0" | |||
There was a problem hiding this comment.
you may also want to update package-lock.json in this directory:
rm -rf package-lock.json
npm i
git add . # etc etc
…be properly interpreted. (DeviaVir#578) The used color.js library does have a "--no-color" switch that should solve the above problem but that library isn't under active development anymore and currently has several bugs regarding the --no-color switch. Since zenbot has a very tight coupling to color.js this is the only way to solve the problem from DeviaVir#578. Solves: DeviaVir#578
|
@DeviaVir I added the missing package-lock.json files with a commit amend |
|
Thank you very much, kind sir! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…be properly interpreted. (#578)
The used color.js library does have a "--no-color" switch that should solve the above problem but that library isn't under active development anymore and currently has several bugs regarding the --no-color switch. Since zenbot has a very tight coupling to color.js this is the only way to solve the problem from #578.
Btw: My codestyle fixed some trailing spaces. Sorry about that ;-) Hope you can merge it anyways.
Solves: #578