This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
CEXIO backfill, balance and incorrect nonce bugfix #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balance undefined and nonce error crash fix. Should fix #641 issue.
nedievas
changed the title
FunFR
reviewed
Oct 23, 2017
| var args = {} | ||
| if (opts.from) { | ||
| args = Number(opts.from) | ||
| } |
There was a problem hiding this comment.
backfill does not work anymore with this code
DeviaVir
approved these changes
Oct 24, 2017
| @@ -176,15 +179,15 @@ module.exports = function container (get, set, clear) { | |||
| var order = orders['~' + opts.order_id] | |||
| var client = authedClient() | |||
| client.get_order_details(opts.order_id, function (err, body) { | |||
| if (err || typeof body === 'undefined') return retry('getOrder', func_args, err) | |||
| if (err || body === 'error: Invalid Order ID') return retry('getOrder', func_args, err) | |||
This was referenced Jan 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
balance undefined and nonce error crash fix. Should fix #641 issue.